Re: [PATCH v29 net-next 5/8] net/nebula-matrix: dispatch: add control-level routing core infrastructure

[netdev-bot+sashiko]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] Commit message describes content the patch does not contain: it
  claims the patch "adds forward definitions of channel wire ABI…

--

net/nebula-matrix: dispatch: add control-level routing core infrastructure

This patch adds the nbl dispatch layer skeleton: it allocates the dispatch
management structure and ops table, wires init_module/deinit_module
wrappers to the resource ops, and tracks control levels in a ctrl_lvl
bitmap. It also adds four channel parameter structures with size
assertions to nbl_def_channel.h.

> This skeleton establishes dispatch management flow. It adds forward
> definitions of channel wire ABI structures and response enums required
> for later channel RPC framework, without implementing message handling.

[Severity: Low]
Could the "and response enums" part of this sentence be dropped or
corrected?  The patch does not appear to add or modify any enum.

The only additions to nbl_def_channel.h are the four structures
nbl_chan_param_cfg_msix_map, nbl_chan_param_set_mailbox_irq,
nbl_chan_param_get_vsi_id and nbl_chan_param_get_eth_id, plus their four
static_assert() size checks:

> diff --git a/drivers/net/ethernet/nebula-matrix/nbl/nbl_include/nbl_def_channel.h b/drivers/net/ethernet/nebula-matrix/nbl/nbl_include/nbl_def_channel.h
> index bf971121d2ecf..c9c99c967037e 100644
> --- a/drivers/net/ethernet/nebula-matrix/nbl/nbl_include/nbl_def_channel.h
> +++ b/drivers/net/ethernet/nebula-matrix/nbl/nbl_include/nbl_def_channel.h
> @@ -39,6 +40,32 @@ enum nbl_chan_state {
>  	NBL_CHAN_STATE_NBITS
>  };
>  
> +struct nbl_chan_param_cfg_msix_map {
> +	__le16 num_net_msix;
> +	__le16 num_others_msix;
> +	__le16 msix_mask_en;
> +	__le16 rsvd;
> +};
> +
> +struct nbl_chan_param_set_mailbox_irq {
> +	__le16 vector_id;
> +	u8 en_msix;
> +	u8 rsvd;
> +};
> +
> +struct nbl_chan_param_get_vsi_id {
> +	__le16 vsi_id;
> +	__le16 type;
> +};
> +
> +struct nbl_chan_param_get_eth_id {
> +	__le16 vsi_id;
> +	u8 eth_num;
> +	u8 eth_id;
> +	u8 logic_eth_id;
> +	u8 rsvd[3];
> +};
> +
>  struct nbl_board_port_info {
>  	u8 eth_num;
>  	u8 eth_speed;

[ ... ]

After this patch, enum nbl_chan_msg_type in the same header is still
unchanged from the baseline:

enum nbl_chan_msg_type {
	NBL_CHAN_MSG_ACK = 0,
	/* mailbox msg end */
	NBL_CHAN_MSG_MAILBOX_MAX,
};

and there is no response or return-code enum added anywhere else in the
patch.

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260922120311.86593-2-illusion.wang%40nebula-matrix.com