Re: [PATCH] phy: ti: omap-usb2: fix OF node leak at probe

From: Manivannan Sadhasivam

Date: Sat Sep 26 2026 - 10:17:26 EST


On Wed, Jul 08, 2026 at 04:12:54PM +0800, Guangshuo Li wrote:
> omap_usb2_probe() parses the ctrl-module phandle and then looks up the
> corresponding platform device.
>
> of_parse_phandle() returns a device node with a reference that must be
> dropped by the caller. The driver currently keeps the device reference
> taken by of_find_device_by_node() until unbind, but never drops the
> temporary OF node reference taken by of_parse_phandle().
>
> Drop the OF node reference after of_find_device_by_node() has consumed
> the node. This covers both the successful lookup path and the

This sentence is abrubtly cut-off.

>
> Fixes: 9955a7835bf3 ("phy: omap-usb2: use *syscon* framework API to power on/off the PHY")

This fixes tag looks wrong. It just uses the syscon API but the leak predates
that commit.

- Mani

--
மணிவண்ணன் சதாசிவம்