Re: [RFC PATCH 1/8] dt-bindings: media: Add bindings for Omnivision OV2312

[Laurent Pinchart]

On Fri, Sep 25, 2026 at 06:59:54PM +0530, Rishikesh Donadkar wrote:
> From: Jai Luthra <j-luthra@xxxxxx>
> 
> Add DT bindings for Omnivision OV2312 camera sensor.
> 
> Signed-off-by: Jai Luthra <j-luthra@xxxxxx>
> Signed-off-by: Rishikesh Donadkar <r-donadkar@xxxxxx>
> ---
>  .../bindings/media/i2c/ovti,ov2312.yaml       | 79 +++++++++++++++++++
>  1 file changed, 79 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov2312.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2312.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov2312.yaml
> new file mode 100644
> index 000000000000..76929fcc6550
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2312.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/ovti,ov2312.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: OmniVision OV2312 Camera Sensor
> +
> +maintainers:
> +  - Jai Luthra <j-luthra@xxxxxx>
> +
> +description: |-
> +  Omnvision OV2312 is a camera sensor with an active array size of 1600x1300.

s/Omnvision/OmniVision/

(although they now seem to style the company name as OMNIVISION)

> +  It supports capture of frames with a 4x4 RGB-IR bayer pattern. This provides
> +  both human (RGB) and machine vision (IR) capabilities in low-light scenarios.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ovti,ov2312
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    const: xvclk

If there's a single clock, drop the name.

> +
> +  reset-gpios:
> +    maxItems: 1
> +    description:
> +      Specifier for the GPIO connected to the RESET pin.

You also need regulators.

> +
> +  port:
> +    $ref: /schemas/graph.yaml#/properties/port
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: ../video-interfaces.yaml#
> +        unevaluatedProperties: false

The sensor supports both CSI-2 and parallel output. You need to be more
precise here regarding the supported properties. The bus type, in
particular, needs to be defined.

> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        camera@60 {
> +            compatible = "ovti,ov2312";
> +            reg = <0x60>;
> +
> +            clocks = <&fixed_clock>;
> +            clock-names = "xvclk";
> +
> +            reset-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
> +
> +            port {
> +                camera1: endpoint {
> +                    remote-endpoint = <&vin1a_ep>;
> +                };
> +            };
> +        };
> +    };
> +
> +...

-- 
Regards,

Laurent Pinchart