Re: [PATCH v2] usbip: vudc: Prevent transfer timer rearm during teardown

[Shuah Khan]

On 9/24/26 15:44, Myeonghun Pak wrote:
> Hi Shuah,
>
> __must_hold records the existing locking requirement for
> v_start_timer() and v_kick_timer(). The old comment was inaccurate
> because v_stop_timer() runs without the lock. timer_shutdown_sync() is
> the actual fix.
>
> The QEMU harness sends CMD_SUBMIT packets while repeatedly unbinding
> and rebinding vudc. It reproduced the bug before the fix and ran 4,000
> iterations without a report afterward. I’ll add this to the v3 commit
> message.
>
> I have not tested with physical devices and a remote client.

Please don't top-post in responses to kernel email reviews.

If you haven't tested this physical devices and a remote client, how
do you know this change fixes the problem. Sorry I can't accept this
patch.

thanks,
-- Shuah