Re: [PATCH v2 2/2] hwmon: (gpd-fan) Register both fans on the GPD Win 5
From: Alexei Solcanu
Date: Sat Sep 26 2026 - 18:15:29 EST
On Sat, 26 Sept 2026 at 23:52, Antheas Kapenekakis <lkml@xxxxxxxxxxx> wrote:
> Actually, recalling what we said last year duo had the new layout but
> only one fan if I recall. Cryolitia can confirm. Then, only Max 3
> needs confirming but even then you still need the new quirk so most of
> this patch is good as is
Cryolitia confirmed the register layout last year in the out-of-tree
driver [1]: the Duo has two duty cycle registers but only one RPM
register, while the Win 5 has two of each.
So v3 keeps the separate win5 board data, inlines the helpers as
ternaries, and adds win5 to gpd_module_drvdata so gpd_fan_board=win5
can be used on the Win Max 3 until it has a DMI entry.
[1] https://github.com/Cryolitia/gpd-fan-driver/pull/21