Re: [PATCH net-next v12 02/15] phylib: Add support for PHYs with broken forced mode

[Birger Koblitz]

On 17/09/2026 11:24 pm, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider:
>
> Critical: 0 · High: 1 · Medium: 1 · Low: 0 (1)
>
> - [High] NULL pointer dereference of `phydev->drv` in
>    phy_ethtool_ksettings_set() (drivers/net/phy/phy.c:1193-1195).
Not sure this is an actuall problem, but will add check on phydev->drv 
as a guard.


> - [Medium] Incomplete gating of PHY_BROKEN_FORCED: the new flag is
>    consulted only in phy_ethtool_ksettings_set()…
I don't think this is an issue as these are direct MII register writes,
the device will just not do what is requested, the PHY_BROKEN_FORCED was
introduced to prevent a stacktrace in phylink.

> Pre-existing issues:
> - [Low] Concern that PHY_BROKEN_FORCED has no in-tree user, making the
>    patch behaviorally inert (dead branch in phy_ethtool_ksettings_set())…
This comes for the relevant PHYs in a later patch of the series.