[PATCH v3 2/8] usb: chipidea: usb2: use devm_clk_get_optional_enabled()

From: Junzhong Pan

Date: Sun Sep 27 2026 - 07:44:48 EST


Convert devm_clk_get_optional() and clk_prepare_enable() into a single
call devm_clk_get_optional_enabled().

Tested-by: Ze Huang <huang.ze@xxxxxxxxx>
Signed-off-by: Junzhong Pan <panjunzhong@xxxxxxxxxxxxxxxxxx>
---
drivers/usb/chipidea/ci_hdrc_usb2.c | 22 ++++++----------------
1 file changed, 6 insertions(+), 16 deletions(-)

diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c
index 8ffa1e95d8e8..9cef902f36b3 100644
--- a/drivers/usb/chipidea/ci_hdrc_usb2.c
+++ b/drivers/usb/chipidea/ci_hdrc_usb2.c
@@ -20,7 +20,6 @@

struct ci_hdrc_usb2_priv {
struct platform_device *ci_pdev;
- struct clk *clk;
};

static const struct ci_hdrc_platform_data ci_default_pdata = {
@@ -52,6 +51,7 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev)
struct ci_hdrc_usb2_priv *priv;
struct ci_hdrc_platform_data *ci_pdata = dev_get_platdata(dev);
const struct ci_hdrc_platform_data *data;
+ struct clk *clk;
int ret;

if (!ci_pdata) {
@@ -70,15 +70,10 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev)
if (!priv)
return -ENOMEM;

- priv->clk = devm_clk_get_optional(dev, NULL);
- if (IS_ERR(priv->clk))
- return PTR_ERR(priv->clk);
-
- ret = clk_prepare_enable(priv->clk);
- if (ret) {
- dev_err(dev, "failed to enable the clock: %d\n", ret);
- return ret;
- }
+ clk = devm_clk_get_optional_enabled(dev, NULL);
+ if (IS_ERR(clk))
+ return dev_err_probe(dev, PTR_ERR(clk),
+ "failed to get or enable the clock\n");

ci_pdata->name = dev_name(dev);

@@ -90,7 +85,7 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev)
dev_err(dev,
"failed to register ci_hdrc platform device: %d\n",
ret);
- goto clk_err;
+ return ret;
}

platform_set_drvdata(pdev, priv);
@@ -99,10 +94,6 @@ static int ci_hdrc_usb2_probe(struct platform_device *pdev)
pm_runtime_enable(dev);

return 0;
-
-clk_err:
- clk_disable_unprepare(priv->clk);
- return ret;
}

static void ci_hdrc_usb2_remove(struct platform_device *pdev)
@@ -111,7 +102,6 @@ static void ci_hdrc_usb2_remove(struct platform_device *pdev)

pm_runtime_disable(&pdev->dev);
ci_hdrc_remove_device(priv->ci_pdev);
- clk_disable_unprepare(priv->clk);
}

static struct platform_driver ci_hdrc_usb2_driver = {

--
2.34.1