Re: [PATCH 1/2] m68k/serial: Use generic BASE_BAUD in asm/serial.h

[Geert Uytterhoeven]

On Fri, 31 Jul 2026 at 11:44, Thorsten Blum <thorsten.blum@xxxxxxxxx> wrote:
> Include asm-generic/serial.h and use the generic BASE_BAUD definition
> instead of redefining it.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>

Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

> --- a/arch/m68k/include/asm/serial.h
> +++ b/arch/m68k/include/asm/serial.h
> @@ -7,15 +7,7 @@
>   *
>   */
>
> -
> -/*
> - * This assumes you have a 1.8432 MHz clock for your UART.
> - *
> - * It'd be nice if someone built a serial card with a 24.576 MHz
> - * clock, since the 16550A is capable of handling a top speed of 1.5
> - * megabits/second; but this requires the faster clock.
> - */
> -#define BASE_BAUD ( 1843200 / 16 )
> +#include <asm-generic/serial.h>
>
>  /* Standard COM flags (except for COM4, because of the 8514 problem) */
>  #ifdef CONFIG_SERIAL_8250_DETECT_IRQ

It would be good if this BASE_BAUD 8250-ism could be removed from
drivers/tty/serial/earlycon.c.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds