Re: [PATCH RESEND net-next v17 00/10] net: phy_port: SFP modules representation and phy_port listing

[Maxime Chevallier]

Hi,

On 9/25/26 00:01, Aleksei Sviridkin wrote:
> Hi Maxime,
> 
> I ran v17 on a Keenetic KN-1012 (MT7981B + MT7531). Switch port 5
> (lan4) goes either to an SFP cage or to an EN8811H copper PHY, and the
> bootloader picks one devicetree variant per boot. The series was
> backported to OpenWrt's 6.18 kernel together with the phy_port base and
> its fixes, with PROVE_LOCKING and DEBUG_ATOMIC_SLEEP enabled.

Thanks for testing :)

[...]

> 
> A module port follows the netdev's admin state rather than module
> presence. With lan4 down, a module sitting in the cage isn't listed,
> because sfp_module_stop() runs phylink_del_sfp_mod_port(). After ifup
> it comes back under a new id, so every ifdown/ifup renumbers it. Is
> that intended? From userspace, "port 3 upstream 1" isn't stable across
> an ifup.

Yes that's intended, we don't really have a choice here. Module ports
should be considered volatile in their id (this is best effort) as they
may disappear / reappear with another module later on.

> 
> Tested-by: Aleksei Sviridkin <f@xxxxxx>

Thanks !

Maxime

> 
> Aleksei