Re: [PATCH] net: phy: aquantia: AQR113c fix up PMA capabilities

[Andrew Lunn]

> [Severity: Medium]
> Does this drop EEE capability discovery on AQR113C?
> 
> Before this patch, the AQR113C entry had neither .features nor
> .get_features, so phy_probe() took the is_c45 branch:
> 
> drivers/net/phy/phy_device.c:phy_probe() {
>     ...
> 	if (phydrv->features) {
> 		linkmode_copy(phydev->supported, phydrv->features);
> 		genphy_c45_read_eee_abilities(phydev);

This is a good point. And it is probably a bigger issue, since none of
the get_feature functions in this driver call
genphy_c45_read_eee_abilities(). Please could you add another patch
the series addressing this.

    Andrew