Re: [PATCH v2 6/9] arm64: cfi: Use CONFIG_ARM64_FUNCTION_PREFIX_NOPS for the type hash offset

From: Jose Fernandez (Anthropic)

Date: Sun Sep 27 2026 - 10:06:50 EST


On Fri, Sep 25, 2026 at 12:17 PM Bill Wendling wrote:
> > + return 4 + 4 * CONFIG_ARM64_FUNCTION_PREFIX_NOPS;
>
> *drive by review* Could you explain the two fours in this equation
> with a comment? (Feel free to ignore this if it's obvious to
> developers.)

The first is the type hash and the second is the size of a NOP. For v3
I'll spell the second one out and add a comment for the first.

/* The 4-byte type hash sits before the prefix NOPs. */
return 4 + CONFIG_ARM64_FUNCTION_PREFIX_NOPS * AARCH64_INSN_SIZE;

- Jose