Re:Re: [PATCH 2/7] net: fec: manage the netdev lifetime with devres
From: jiale yao
Date: Sun Sep 27 2026 - 10:58:20 EST
Hi Francesco,
Thanks for the review. Sorry I missed that — I've fixed the empty
lines between the tags, and applied the same to the other commits.
in https://lore.kernel.org/all/20260927144741.1320558-1-yaojiale02@xxxxxxx/
At 2026-09-27 22:37:45, "Francesco Dolcini" <francesco@xxxxxxxxxx> wrote:
>On Sun, Sep 27, 2026 at 07:09:59PM +0800, Jiale Yao wrote:
>> fec_drv_remove() frees the netdev before devres releases the managed
>> IRQs whose handlers use it as their data pointer. A late interrupt can
>> therefore access the freed netdev.
>>
>> Allocate the netdev with devres so that the later IRQ registrations are
>> released first during teardown.
>>
>> Fixes: 0d9b2ab1c376 ("fec: Use devm_request_irq()")
>>
>remove the empty line, tags should be all together without any empty
>line in-between. same applies to the other commits.
>> Cc: stable@xxxxxxxxxxxxxxx
>> Signed-off-by: Jiale Yao <yaojiale02@xxxxxxx>
>
>Francesco
Jiale