Re: [PATCH net v3 2/2] net: ethtool: let tsconfig reach a PHY-only timestamp provider

[Kory Maincent]

On 9/25/26 15:52, Nicolai Buchwitz wrote:
> TSCONFIG_GET and TSCONFIG_SET reject a device that implements neither
> hwtstamp NDO, even when its PHY can serve the request. The ioctls they
> meant to replace handle it, so the two interfaces disagree on the same
> hardware and user space has to pick one.
>
> Accept the default timestamping PHY and an already installed provider on
> both sides. On the set side the test moves into ethnl_set_tsconfig() as
> the validate callback runs without rtnl. On the get side it stays ahead
> of ethnl_ops_begin(), so a device that can serve nothing keeps failing
> with EOPNOTSUPP and a dump still skips it rather than stopping there.
>
> A netdev provider needs ndo_hwtstamp_set to be programmed at all, so
> don't pick that source without it, and test for ndo_hwtstamp_get before
> calling it.
>
> Fixes: 6e9e2eed4f39 ("net: ethtool: Add support for tsconfig command to get/set hwtstamp config")
> Signed-off-by: Nicolai Buchwitz <nb@xxxxxxxxxxx>

Reviewed-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>

Thank you!
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com