[PATCH v4 4/5] hwmon: (aquacomputer_d5next) Skip unknown firmware version offsets

From: Vas Zayarskiy

Date: Sun Sep 27 2026 - 14:38:01 EST


Only decode the firmware version when its offset is known, matching the
condition used to expose the firmware_version debugfs file. This lets a
device leave the offset at zero without interpreting the report ID and
following byte as a firmware version.

Assisted-by: LLM sparse
Signed-off-by: Vas Zayarskiy <contact@xxxxxxxxx>
---
drivers/hwmon/aquacomputer_d5next.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/aquacomputer_d5next.c b/drivers/hwmon/aquacomputer_d5next.c
index d4ed204ca..5c0c47eb0 100644
--- a/drivers/hwmon/aquacomputer_d5next.c
+++ b/drivers/hwmon/aquacomputer_d5next.c
@@ -1342,7 +1342,8 @@ static int aqc_raw_event(struct hid_device *hdev, struct hid_report *report, u8
priv->serial_number[0] = get_unaligned_be16(data + priv->serial_number_start_offset);
priv->serial_number[1] = get_unaligned_be16(data + priv->serial_number_start_offset +
SERIAL_PART_OFFSET);
- priv->firmware_version = get_unaligned_be16(data + priv->firmware_version_offset);
+ if (priv->firmware_version_offset)
+ priv->firmware_version = get_unaligned_be16(data + priv->firmware_version_offset);

/* Physical temperature sensor readings */
for (i = 0; i < priv->num_temp_sensors; i++) {