Re: [PATCH v6 00/14] HID: iio: Introduce devm_ APIs for HID sensors

[Jonathan Cameron]

On Sat, 19 Sep 2026 16:06:23 +0530
Sanjay Chitroda via B4 Relay <devnull+sanjayembeddedse.gmail.com@xxxxxxxxxx> wrote:

> Following feedback from reviewers and Srinivas, v4 series was split
> into two additional sub-series to perform cleanup and preparatory work
> before adding devm support:
> - HID: iio: warning clean up and prefer kernel coding style
>   https://lore.kernel.org/all/20260707-15-jun-hid-iio-alignment-v3-0-8791574ad0fe@xxxxxxxxx/
> - HID: iio: basic clean up for usage_id
>   https://lore.kernel.org/all/20260610-6-june-hid-iio-correct-usage-id-v2-0-c3c5f0720493@xxxxxxxxx/
> 
> Both series have been merged into IIO tree. This series introduces
> device-managed APIs and converts HID IIO sensor drivers to use the new
> devm-managed resources.
> 
> checkpatch reports a "suspect code indent" warning on the DEFINE_FREE()
> declaration, but this appears to be a false positive caused by the macro
> expansion. The code builds cleanly.
If possible, Zhang Lixu, would you mind retesting this full set?

I think the more recent changes in this are unlikely to cause problems
but would also prefer to have some more tags on this in general before
I pick it up, so if Srinivas or anyone else has time to take a look
that would be great.

Thanks

Jonathan

> 
> Changes in v6:
> - Following input from Andy rectify kernel-doc for return
> - With input from Jonathan used devres framework implemetation with
>   cleanup helpder to reduce complexity and resource allocation.
> - Link to v5: https://patch.msgid.link/20260806-28-apr-iio-redundant-argument-v5-temp-v5-0-f1f92c1d830f@xxxxxxxxx
> Changes in v5:
> - With input from Jonathan, convert all HID IIO drivers to use
>   fully devm instead of partial or specific API; this is potential
>   goal and validation on that will reduce multiple validation cycle.
> - Rebase changes on latest iio/testing tree and resolve merge conflict
> - Resolve mail client issue as v4 series was splitted into sub-series
> - Link to v5: https://lore.kernel.org/all/20260524192059.1193716-1-sanjayembedded@xxxxxxxxx/
> Changes in v4:
> - Extend the series to cover remaining HID IIO drivers with devm API usage
> - Reorder patches to place cleanup and warning fix at beginning and,
>   devm-related changes toward the end based on feedback from David
> - v3 series -> https://lore.kernel.org/all/20260509101040.791404-1-sanjayembedded@xxxxxxxxx/
> Changes in v3:
> - Added cleanup and prepratory changes before adding devm_ API
>   conversion based on self review: 0002, 0004, 0006, 0007 and 0008
> - Address andy's review comment on commit message and coding style
> - v2 series -> https://lore.kernel.org/all/20260429175918.2541914-1-sanjayembedded@xxxxxxxxx/
> Changes in v2:
> - Following input from Jonathan and Andy, squash initial patch v1
>   series in single change as individual change should not break anything
> - Add devm API support and two driver using the same
> - v1 series -> https://lore.kernel.org/all/20260428071613.1134053-1-sanjayembedded@xxxxxxxxx/
> 
> Testing:
>   - Compiled with W=1 for each patch in series
> PS:
> - Sashiko reported an issue in a different driver and noted that it is not
>   introduced by this series. I have taken this feedback into account and
>   will address the actual issue in a separate series focus on that driver.
> - Following input from Jonathan, will prepare followup series for
>   HID IIO drivers to consistency support for logs in probe() path
> 
> ---
> Sanjay Chitroda (14):
>       iio: hid-sensors: remove unused iio_dev argument
>       iio: hid-sensors: introduce device managed API
>       HID: hid-sensor-hub: introduce device managed API
>       iio: gyro: hid-sensor-gyro-3d: convert probe and teardown to devm-managed resources
>       iio: accel: hid-sensor-accel-3d: convert probe and teardown to devm-managed resources
>       iio: humidity: hid-sensor-humidity: convert probe and teardown to devm-managed resources
>       iio: light: hid-sensor-prox: convert probe and teardown to devm-managed resources
>       iio: light: hid-sensor-als: convert probe and teardown to devm-managed resources
>       iio: magnetometer: hid-sensor-magn-3d: convert probe and teardown to devm-managed resources
>       iio: orientation: hid-sensor-incl-3d: convert probe and teardown to devm-managed resources
>       iio: orientation: hid-sensor-rotation: convert probe and teardown to devm-managed resources
>       iio: position: hid-sensor-custom-intel-hinge: convert probe and teardown to devm-managed resources
>       iio: pressure: hid-sensor-press: convert probe and teardown to devm-managed resources
>       iio: temperature: hid-sensor-temperature: convert probe and teardown to devm-managed resources
> 
>  drivers/hid/hid-sensor-hub.c                       | 35 ++++++++++++++++++
>  drivers/iio/accel/hid-sensor-accel-3d.c            | 40 +++++----------------
>  .../iio/common/hid-sensors/hid-sensor-trigger.c    | 21 +++++++++--
>  .../iio/common/hid-sensors/hid-sensor-trigger.h    |  5 +--
>  drivers/iio/gyro/hid-sensor-gyro-3d.c              | 41 +++++----------------
>  drivers/iio/humidity/hid-sensor-humidity.c         | 38 +++++---------------
>  drivers/iio/light/hid-sensor-als.c                 | 39 +++++---------------
>  drivers/iio/light/hid-sensor-prox.c                | 40 +++++----------------
>  drivers/iio/magnetometer/hid-sensor-magn-3d.c      | 41 +++++----------------
>  drivers/iio/orientation/hid-sensor-incl-3d.c       | 42 +++++-----------------
>  drivers/iio/orientation/hid-sensor-rotation.c      | 40 +++++----------------
>  .../iio/position/hid-sensor-custom-intel-hinge.c   | 38 ++++----------------
>  drivers/iio/pressure/hid-sensor-press.c            | 41 +++++----------------
>  drivers/iio/temperature/hid-sensor-temperature.c   | 39 +++++---------------
>  include/linux/hid-sensor-hub.h                     | 26 ++++++++++++++
>  15 files changed, 175 insertions(+), 351 deletions(-)
> ---
> base-commit: 9c464e7473f762cee4c031a09da04f65a1c65d49
> change-id: 20260603-28-apr-iio-redundant-argument-v5-temp-4e49eed863af
> 
> Best regards,
> --  
> Sanjay Chitroda <sanjayembeddedse@xxxxxxxxx>
> 
>