Re: [PATCH net-next v2 1/9] netlink: specs: rt-link: re-align IPv4 devconf

[Hangbin Liu]

On Fri, Sep 25, 2026 at 09:39:04PM +0000, Asbjørn Sloth Tønnesen wrote:
> The YNL "ipv4-devconf" enum is misaligned with the IPV4_DEVCONF_* enum.
> 
> IPV4_DEVCONF_* starts at 1, ipv4-devconf starts at 0.
> 
> $ git grep -B3 -A1 IPV4_DEVCONF_FORWARDING include/
> inc../uapi/linux/ip.h-/* index values for the variables in ipv4_devconf */
> inc../uapi/linux/ip.h-enum
> inc../uapi/linux/ip.h-{
> inc../uapi/linux/ip.h:        IPV4_DEVCONF_FORWARDING=1,
> inc../uapi/linux/ip.h-        IPV4_DEVCONF_MC_FORWARDING,
> 
> Re-align the YNL spec by explicitly setting the first value to 1.
> 
> This misalignment has been present since the spec was added in
> commit b2f63d904e72 ("doc/netlink: Add spec for rt link messages").
> 
> Reviewed-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@xxxxxxxxxxx>
> ---
> Note for Sashiko/Clashiko: Targeting net-next, so no "Fixes" tag.
> 
>  Documentation/netlink/specs/rt-link.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml
> index 7a72cd1b7e1e..8d63933f9910 100644
> --- a/Documentation/netlink/specs/rt-link.yaml
> +++ b/Documentation/netlink/specs/rt-link.yaml
> @@ -309,6 +309,7 @@ definitions:
>      entries:
>        -
>          name: forwarding
> +        value: 1
>        -
>          name: mc-forwarding
>        -
> -- 
> 2.55.0
> 

Reviewed-by: Hangbin Liu <liuhangbin@xxxxxxxxxx>