Re: [PATCH v9 1/2] dt-bindings: clock: add TI CDCE6214 binding

[Krzysztof Kozlowski]

On Mon, Sep 21, 2026 at 08:49:59AM +0200, Sascha Hauer wrote:
> +properties:
> +  compatible:
> +    enum:
> +      - ti,cdce6214
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    minItems: 1
> +    maxItems: 2
> +
> +  clock-names:
> +    oneOf:
> +      - items:
> +          - enum: [ priref, secref ]
> +      - items:
> +          - const: priref
> +          - const: secref

Entire oneOf can be simpler:
minItems: 1
items:
  - enum: [ priref, secref ]
  - const: secref

> +
> +  '#clock-cells':
> +    const: 1
> +
> +patternProperties:
> +  '-pins$':
> +    type: object
> +    additionalProperties: false
> +
> +    patternProperties:
> +      '^conf':

Style prefers suffixes after hyphen, so:
'^conf-'

> +        type: object
> +        additionalProperties: false
> +        $ref: /schemas/pinctrl/pincfg-node.yaml#

...

> diff --git a/include/dt-bindings/clock/ti,cdce6214.h b/include/dt-bindings/clock/ti,cdce6214.h
> new file mode 100644
> index 0000000000000..41ec4f8868bbb
> --- /dev/null
> +++ b/include/dt-bindings/clock/ti,cdce6214.h
> @@ -0,0 +1,25 @@
> +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
> +#ifndef _DT_BINDINGS_CLK_TI_CDCE6214_H
> +#define _DT_BINDINGS_CLK_TI_CDCE6214_H
> +
> +/* Clock indices for the clocks provided by the CDCE6214 */
> +#define CDCE6214_CLK_OUT0	2

Please start at 0 or 1

> +#define CDCE6214_CLK_OUT1	3
> +#define CDCE6214_CLK_OUT2	4
> +#define CDCE6214_CLK_OUT3	5
> +#define CDCE6214_CLK_OUT4	6
> +#define CDCE6214_CLK_PLL	7
> +#define CDCE6214_CLK_PSA	8
> +#define CDCE6214_CLK_PSB	9

Best regards,
Krzysztof