Re: [PATCH] ata: libata: Fix scsi_done() documentation

[Damien Le Moal]

On 2026/09/25 20:05, Bart Van Assche wrote:
> In 2008 the SCSI core was converted to use the block layer timeout
> infrastructure instead of its own infrastructure (see also patch
> "block: unify request timeout handling"). Since then, calling
> scsi_done() while SCSI host recovery is in progress has no effect.
> Originally the REQ_ATOM_COMPLETE flag was used to prevent double
> completions. Today the SCMD_STATE_COMPLETE flag is used to prevent
> double completions.
> 
> Instead of mentioning that calling scsi_done() is not allowed while
> host recovery is in progress, mention that it has no effect.
> 
> Cc: Damien Le Moal <dlemoal@xxxxxxxxxx>
> Cc: Niklas Cassel <cassel@xxxxxxxxxx>
> Cc: linux-ide@xxxxxxxxxxxxxxx
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>


-- 
Damien Le Moal
Western Digital Research