Re: [PATCH v4 1/8] ASoC: dt-bindings: qcom: Add Shikra RX and VA macro codecs

[Krzysztof Kozlowski]

On Tue, Sep 22, 2026 at 03:12:30PM +0530, Mohammad Rafi Shaik wrote:
> Document compatibles for Qualcomm shikra rx and va macro codecs.
> This SoC does not provide macro and dcodec clock so reflect that in
> the bindings.
> 
> Shikra integrates LPASS codec version 4.1, which is not backwards
> compatible with the already described compatibles.
> 
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@xxxxxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/sound/qcom,lpass-rx-macro.yaml  | 17 +++++++++++++++++
>  .../devicetree/bindings/sound/qcom,lpass-va-macro.yaml  | 17 +++++++++++++++++
>  2 files changed, 34 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
> index 4988e7ed6e34..69d7b7332d36 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
> @@ -14,6 +14,7 @@ properties:
>      oneOf:
>        - enum:
>            - qcom,sc7280-lpass-rx-macro
> +          - qcom,shikra-lpass-rx-macro
>            - qcom,sm6115-lpass-rx-macro
>            - qcom,sm8250-lpass-rx-macro
>            - qcom,sm8450-lpass-rx-macro
> @@ -138,6 +139,22 @@ allOf:
>              - const: dcodec
>              - const: fsgen
>  
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - qcom,shikra-lpass-rx-macro
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 3

You can drop this one, it's already set in top-level.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof