Re: [PATCH v2 0/2] of/irq: msi-parent handling in of_msi_xlate()

[Fuad Tabba]

Hi Rob, Saravana,

On Mon, 7 Sept 2026 at 12:29, Fuad Tabba <fuad.tabba@xxxxxxxxx> wrote:
>
> Hi folks,
>
> Changes since v1 [1]:
>   - Added patch 2: end the walk at the first node that declares an
>     msi-parent, with the reference handling moved into of_msi_xlate().
>     (Lorenzo)
>   - Patch 1 is unchanged.

Gentle ping on this one. Patch 2 is the msi-parent walk change Lorenzo
suggested on v1. Anything else needed for it to go in?

Cheers,
/fuad

>
> Patch 1 is the v1 fix: of_check_msi_parent() hands back a node reference
> even when the caller passed one in as a filter, which of_msi_xlate()
> documents as receiving none. Patch 2 is what Lorenzo asked for [2]: a
> node declaring an msi-parent names the MSI controller for what sits
> below it, so the walk ends there rather than carrying on to an
> ancestor's msi-map.
>
> Patch 2 removes the line patch 1 adds, along with the rest of the
> reference handling. They stay separate because patch 1 is a small fix
> for a leak that has been there since v6.18, and patch 2 changes
> behaviour: folding them would hide the fix inside the change.
>
> Based on Linux 7.3-rc1 (cee9395acd804).
>
> Cheers,
> /fuad
>
> [1] https://lore.kernel.org/all/20260904073424.3855365-1-fuad.tabba@xxxxxxxxx/
> [2] https://lore.kernel.org/all/apqnaNmeuUjfC8Ng@red-moon/
>
> Fuad Tabba (2):
>   of/irq: Fix device node refcount leak in of_check_msi_parent()
>   of/irq: Stop the MSI walk at the first msi-parent
>
>  drivers/of/irq.c | 39 ++++++++++++++++++++++-----------------
>  1 file changed, 22 insertions(+), 17 deletions(-)
>
> --
> 2.39.5
>