Re: [PATCH 1/4] platform/x86: int3472: Map the VD55G1 power enable GPIO to "vana"

[Benjamin Mugnier]

Hi Ruslan,

Thank you for your patch.

Le 24/09/2026 à 19:18, Ruslan Koreev a écrit :
> The Lenovo ThinkPad X1 Carbon Gen 14 has an ST VD55G1 IR camera, ACPI
> HID TBE20A1, behind an INT3472 discrete device that provides a power
> enable GPIO, a reset GPIO and a privacy LED. The vd55g1 driver names its

About the privacy LED, the driver powers on the device at probe to
detect its version, so the privacy led might flash at boot. This is a
problem we could handle latter on.

> analog supply "vana", so map the power enable regulator to that name, as
> is already done for the imx471 on the same laptop.
> 
> Signed-off-by: Ruslan Koreev <koreev.r@xxxxxxxxx>

I'm not comfortable enough on ACPI to do a proper review. If it works
for you then :

Acked-by: Benjamin Mugnier <benjamin.mugnier@xxxxxxxxxxx>

> ---
>  drivers/platform/x86/intel/int3472/discrete.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c
> index 6c729fcfc..d005595ba 100644
> --- a/drivers/platform/x86/intel/int3472/discrete.c
> +++ b/drivers/platform/x86/intel/int3472/discrete.c
> @@ -130,6 +130,7 @@ skl_int3472_gpiod_get_from_temp_lookup(struct int3472_discrete_device *int3472,
>  static const char * const power_enable_hids_vana[] = {
>  	"SONY471A", /* imx471 on Lenovo X9-14 and X9-15 */
>  	"TBE20A0", /* imx471 on Lenovo X1 Carbon G14 */
> +	"TBE20A1", /* vd55g1 on Lenovo X1 Carbon G14 */
>  	NULL
>  };
>  

-- 
Regards,
Benjamin