Re: [PATCH 2/4] media: ipu-bridge: Add the ST VD55G1 (TBE20A1)

[Benjamin Mugnier]

Hi Ruslan,

Le 24/09/2026 à 19:18, Ruslan Koreev a écrit :
> Add the ACPI HID Lenovo uses for the ST VD55G1 IR camera of the ThinkPad
> X1 Carbon Gen 14. The firmware describes one CSI-2 data lane and, as
> usual, no link frequency, so the value has to come from this table; the
> vd55g1 driver requires exactly one.
> 
> Use 402 MHz (804 Mbps). The sensor derives its MIPI rate and clock tree
> from this value and the IPU7 CSI-2 receiver reads the same value back
> through V4L2_CID_LINK_FREQ, so both ends agree by construction. At
> 804 Mbps a full-width 10-bit line takes about 11 us on the link, which
> allows well over 100 fps at full resolution; lower rates lengthen every
> line proportionally. The rate is in the lower half of the 250 to
> 1200 Mbps range the sensor supports and is the one validated on the
> hardware, where 804x704 streams at 58 fps.
> 
> Signed-off-by: Ruslan Koreev <koreev.r@xxxxxxxxx>

Acked-by: Benjamin Mugnier <benjamin.mugnier@xxxxxxxxxxx>

> ---
>  drivers/media/pci/intel/ipu-bridge.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
> index bd64c0400..5941428ed 100644
> --- a/drivers/media/pci/intel/ipu-bridge.c
> +++ b/drivers/media/pci/intel/ipu-bridge.c
> @@ -101,6 +101,8 @@ static const struct ipu_sensor_config ipu_supported_sensors[] = {
>  	IPU_SENSOR_CONFIG("SONY471A", 1, 200000000),
>  	/* Sony IMX471 (found on Lenovo X1 Carbon G14) */
>  	IPU_SENSOR_CONFIG("TBE20A0", 1, 200000000),
> +	/* STMicroelectronics VD55G1 (found on Lenovo X1 Carbon G14) */
> +	IPU_SENSOR_CONFIG("TBE20A1", 1, 402000000),
>  	/* Toshiba T4KA3 */
>  	IPU_SENSOR_CONFIG("XMCC0003", 1, 321468000),
>  };

-- 
Regards,
Benjamin