Re: [PATCH] pinctrl: qcom: ipq5018: add required gpios and missing PWM functions
From: George Moussalem
Date: Mon Sep 28 2026 - 05:22:21 EST
On 9/28/26 12:38, Bartosz Golaszewski wrote:
> On Thu, 24 Sep 2026 14:22:11 +0200, George Moussalem via B4 Relay
> <devnull+george.moussalem.outlook.com@xxxxxxxxxx> said:
>> From: George Moussalem <george.moussalem@xxxxxxxxxxx>
>>
>> On multiple Linksys routers, GPIO 1, 30, and 46 are used to drive the
>> PWM led on PWM1, PWM3, and PWM0 channels respectively, so let's update
>> the pwm# and pingroups accordingly.
>>
>> Signed-off-by: George Moussalem <george.moussalem@xxxxxxxxxxx>
>> ---
>
> Are we *updating* or *adding missing*? Depending on the answer, this can be
> interpreted as a fix that should be backported or a new feature that should
> be queued for v7.4.
Not all IPQ5018 routers have these GPIOs assigned to these PWM groups so
I suppose it's not a fix but rather an update. I'll send v2 out shortly
with an updated commit title.
>
> If this is a fix, can you add a Fixes tag?
>
> Bart
George