Re: [PATCH v5 1/7] ASoC: SDCA: allow building without ACPI

From: Charles Keepax

Date: Mon Sep 28 2026 - 05:35:35 EST


On Fri, Sep 25, 2026 at 05:10:42PM +0100, Srinivas Kandagatla wrote:
> The SDCA class driver is useful on non-ACPI platforms where the
> topology is supplied statically via sdca_class_ops.populate_function.
>
> Drop 'depends on ACPI' from SND_SOC_SDCA and guard the ACPI-specific
> enumeration helpers (sdca_lookup_functions, sdca_lookup_swft,
> sdca_lookup_interface_revision) in sdca_device.c and sdca_functions.c
> with IS_ENABLED(CONFIG_ACPI), providing empty stubs when ACPI is off.
>
> The fwnode-based DisCo parser (sdca_parse_function() and its helpers
> in sdca_functions.c) stays compiled unconditionally: it uses only
> fwnode_* APIs and can in principle be reached from any firmware
> backend that supplies a matching device tree.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles