Re: [PATCH v1 12/27] dt-bindings: gpu: panthor: Document panthor-arbitration bindings

[Krzysztof Kozlowski]

On Tue, Sep 22, 2026 at 09:45:06PM +0100, Karunika Choo wrote:
> Mali 5th-Gen AM GPUs expose arbitration registers outside the GPU node.
> The arbitration device contains partition-control and resource-group
> register blocks used to grant, yield, and close access windows.
> 
> Document partition and resource-group child nodes, each with its own
> register range, interrupt and hardware ID.
> 
> Signed-off-by: Karunika Choo <karunika.choo@xxxxxxx>
> ---
>  .../gpu/arm,mali-gen5-am-arbitration.yaml     | 125 ++++++++++++++++++
>  .../bindings/gpu/arm,mali-gen5-am-system.yaml |   9 ++
>  2 files changed, 134 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-gen5-am-arbitration.yaml
> 
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-gen5-am-arbitration.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-gen5-am-arbitration.yaml
> new file mode 100644
> index 0000000000000..9ea2b4bb9a344
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-gen5-am-arbitration.yaml
> @@ -0,0 +1,125 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +# Copyright 2026 ARM Limited. All rights reserved.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpu/arm,mali-gen5-am-arbitration.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ARM Mali 5th-Gen GPU Arbitration Device
> +
> +maintainers:
> +  - Liviu Dudau <liviu.dudau@xxxxxxx>
> +  - Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> +
> +description:
> +  The arbitration device manages partition-control and resource-group blocks.
> +  Each block is described by a child node with its own register range,
> +  interrupt and hardware ID. Partition and resource-group IDs are separate
> +  namespaces. Access-window IDs are global to the GPU.
> +
> +properties:
> +  $nodename:
> +    const: panthor-arbitration

Same comments. I stopped review here except one more point:


> +
> +  compatible:
> +    const: arm,mali-gen5-am-arbitration
> +
> +  "#address-cells": true
> +
> +  "#size-cells": true
> +
> +  ranges: true
> +
> +patternProperties:
> +  "^partition@[0-9a-f]+$":
> +    type: object
> +    additionalProperties: false
> +    description:
> +      Partition control block and its initial resource assignments.
> +
> +    properties:
> +      reg:
> +        maxItems: 1
> +        description: Partition control register range.
> +
> +      interrupts:
> +        maxItems: 1
> +        description: Partition control interrupt.
> +
> +      arm,id:
> +        $ref: /schemas/types.yaml#/definitions/uint32

IDs are not allowed. See writing bindings or DTS101 slides.

Best regards,
Krzysztof