Re: [PATCH v3 4/5] media: uvcvideo: Do not parse bmVideoStandards

[Hans de Goede]

Hi,

On 11-Sep-26 15:22, Ricardo Ribalda wrote:
> bmVideoStandards is write only, so there is no need to parse it.
> 
> Remove it.
> 
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <johannes.goede@xxxxxxxxxxxxxxxx>

Regards,

Hans


> ---
>  drivers/media/usb/uvc/uvc_driver.c | 7 -------
>  drivers/media/usb/uvc/uvcvideo.h   | 1 -
>  2 files changed, 8 deletions(-)
> 
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index ca75f8d1ec46..adec9d1aa653 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -1187,13 +1187,6 @@ static int uvc_parse_standard_control(struct uvc_device *dev,
>  		unit->processing.bmControls = (u8 *)unit + sizeof(*unit);
>  		memcpy(unit->processing.bmControls, &buffer[8], n);
>  
> -		/*
> -		 * We are not using bmVideoStandards, so there is no need to
> -		 * warn the user if it is missing.
> -		 */
> -		if (dev->uvc_version >= 0x0110 && buflen >= (n + 10))
> -			unit->processing.bmVideoStandards = buffer[9+n];
> -
>  		uvc_entity_set_name(dev, unit, "Processing", buffer[8+n]);
>  
>  		list_add_tail(&unit->list, &dev->entities);
> diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h
> index 8d99e857a69f..65f232de7821 100644
> --- a/drivers/media/usb/uvc/uvcvideo.h
> +++ b/drivers/media/usb/uvc/uvcvideo.h
> @@ -228,7 +228,6 @@ struct uvc_entity {
>  			u16 wMaxMultiplier;
>  			u8  bControlSize;
>  			u8  *bmControls;
> -			u8  bmVideoStandards;
>  		} processing;
>  
>  		struct {
>