Re: [PATCH net-next v12 09/15] ax88179_178a: Add VLAN offload support for AX88179A

[Andrew Lunn]

On Mon, Sep 28, 2026 at 06:41:09AM +0200, Birger Koblitz wrote:
> On 27/09/2026 4:24 pm, Andrew Lunn wrote:
> > > You ask: On a busy bus, or when a transfer stalls and hits the timeout, this
> > > blocks
> > >    all other network configuration in the system for a long time.  Could the
> > >    clear be limited to rows actually in use, batched, or moved out of the
> > > RTNL
> > >    section?
> > 
> > How long does this typically take?
> > 
> > And what is the worst case, if the device is hot-unplugged?
> > 
> > If these values are small, i don't think it is an issue.
> > 
> 
> I tested this on an AX88279 with SS and AX88772D with FS.
> In both cases the time to update the VLAN offload table is 165ms, there is
> very little statistical variation, since 768 transfers are made, averaging
> out the individual transfer times.
> 
> I then did
> sudo ethtool -K enx6c6e07090001 rx-vlan-filter on
> and unplugged immediately the device. This is not an issue at all, since now
> all transfers fail immediately, so the whole table setting takes 2ms
> and then the device disappears.
> 
> Finally, I started iperf transferring 2.5GBit/s and only then changed
> rx-vlan-filter. The time to completion was now 173ms.
> 
> I really do not believe this to be a problem.

Yes, i agree, these numbers are all small. Thanks for doing the
measurements.

     Andrew