Re: [PATCH net-next] net: bcmgenet: complete Tx NAPI after one reclaim pass

[Eric Dumazet]

On Mon, Sep 28, 2026 at 3:14 PM Eric Dumazet <edumazet@xxxxxxxxxx> wrote:
>
> On Mon, Sep 28, 2026 at 2:15 PM Nicolai Buchwitz <nb@xxxxxxxxxxx> wrote:
> >
> > After reclaiming, the Tx poll asks to be polled again. That extra poll
> > finds nothing to do and does not reduce the interrupt rate.
> >
> > Complete the NAPI and unmask the ring interrupt right after the reclaim.
> >
> > On a CM4 this raises 60 byte pktgen Tx from about 187k to 224k pps and
> > saves about 5% of one core at TCP line rate.
>
> Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>
>
> As a follow-up, you can get rid of ring->lock in the TX
> fastpath altogether (it looks like a leftover from before TX reclaim
> was moved to NAPI in commit 4092e6acf5cb ("net: bcmgenet: use NAPI for
> Tx completion")).

The commit sha1 is correct, but its true title was:
("net: bcmgenet: fix throughtput regression")).

(Even if this was a NAPI adoption for TX completions)