Re: [PATCH RFC] gpio: move intel drivers into their own directory
From: Andy Shevchenko
Date: Mon Sep 28 2026 - 09:50:26 EST
On Mon, Sep 28, 2026 at 3:25 PM Bartosz Golaszewski <brgl@xxxxxxxxxx> wrote:
> On Mon, 28 Sep 2026 13:34:44 +0200, Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> said:
> > On Mon, Sep 28, 2026 at 2:13 PM Bartosz Golaszewski <brgl@xxxxxxxxxx> wrote:
> >> On Sat, 26 Sep 2026 12:07:27 +0200, Mika Westerberg
> >> <mika.westerberg@xxxxxxxxxxxxxxx> said:
> >> > On Fri, Sep 25, 2026 at 05:34:53PM +0300, Andy Shevchenko wrote:
> >> >> On Fri, Sep 25, 2026 at 02:54:33PM +0200, Mika Westerberg wrote:
> >> >> > On Fri, Sep 25, 2026 at 01:48:05PM +0300, Andy Shevchenko wrote:
> >> >> > > On Fri, Sep 25, 2026 at 12:22:15PM +0200, Bartosz Golaszewski wrote:
...
> >> >> > > > drivers/gpio/{ => intel}/gpio-graniterapids.c | 0
> >> >> > > > drivers/gpio/{ => intel}/gpio-novalake-events.c | 0
> >> >> > >
> >> >> > > These are interesting drivers, not sure where to put them
> >> >> >
> >> >> > IMHO they should be there too. We are maintaining them both.
> >> >>
> >> >> Do you send PRs to Bart or you just rely on him to take the patches?
> >> >
> >> > I don't expect these two drives to get too much attention, and they could
> >> > be contained nicely inside intel folder and that would help Bart to
> >> > identify that these are Intel drivers. So your bandwidth would not suffer
> >> > even if these two are added there. Your call.
> >>
> >> I'd like to avoid a situation where we have Andy's Intel drivers under
> >> drivers/gpio/intel/ and other Intel drivers under drivers/gpio/. I'd prefer
> >> to move all of intel GPIO drivers into drivers/gpio/intel/ and have Andy
> >> gather changes to them if he agrees.
> >
> > Okay, we have two parts missing:
> > - Nova Lake driver (I would need Adam or Mika to step in as at least a
> > designated reviewer for that)
>
> Acked.
>
> > - USB IO (I think we need to agree which tree it will go through, my
> > bet that media tree is the best), for that we need Hans' consent
>
> So far the initial commit was picked up by Greg and the other two were
> signed-off by me with Acks from intel people.
>
> I'd do the same thing as for nova lake: Israel, Hans and Sakari as reviewers
> and you queue the changes?
I'm fine with this route as well. Since Hans replied, this all depends
on Sakari's answer.
--
With Best Regards,
Andy Shevchenko