Re: [PATCH v2] platform/x86/amd/pmc: Add Thinkpad L14 Gen3 (21C5) to quirk_s2idle_bug

[Mario Limonciello]

On 9/28/26 11:06, Bruno BOI wrote:
> The Thinkpad L14 Gen3 with DMI product name 21C5 is affected by the same
> s2idle resume stall as the already listed 21C6 variant: resuming from
> s2idle blocks for several seconds before the kernel resumes.
>
> DMI_MATCH() performs substring matching, so a "21C5" entry also covers
> SKUs such as 21C5S05800. Add the 21C5 model to the existing
> quirk_s2idle_bug table.
>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=222070
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=221273
> Signed-off-by: Bruno BOI <bruno.boi@xxxxxxxxxxx>
> ---
> Changes in v2: resent with the correct sender address; the patch
> content is unchanged from v1.
>   drivers/platform/x86/amd/pmc/pmc-quirks.c | 9 +++++++++
>   1 file changed, 9 insertions(+)

Mark,

Since it uses prefixes rather than a new entry how would you feel about:

DMI_MATCH(DMI_PRODUCT_NAME, "21C"),

On the 21C6 existing entry.
> diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c
> index 74ddf1d..c3fabc9 100644
> --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c
> +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c
> @@ -246,6 +246,15 @@ static const struct dmi_system_id fwbug_list[] = {
>   			DMI_MATCH(DMI_PRODUCT_NAME, "21C6"),
>   		}
>   	},
> +	/* https://bugzilla.kernel.org/show_bug.cgi?id=221273 */
> +	{
> +		.ident = "Thinkpad L14 Gen3",
> +		.driver_data = &quirk_s2idle_bug,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "21C5"),
> +		}
> +	},
>   	/* https://gitlab.freedesktop.org/drm/amd/-/issues/4434 */
>   	{
>   		.ident = "Lenovo Yoga 6 13ALC6",