Re: [PATCH net v2 02/10] net: systemport: Fix invalid dev_id argument in bcm_sysport_poll_controller()
From: Jakub Kicinski
Date: Mon Sep 28 2026 - 20:01:39 EST
On Tue, 22 Sep 2026 16:24:32 -0700 Florian Fainelli wrote:
> Both bcm_sysport_rx_isr() and bcm_sysport_tx_isr() expect their second
> argument (dev_id) to be a 'struct net_device *dev', as they call
> netdev_priv(dev) to retrieve the private data structure.
>
> bcm_sysport_poll_controller() was passing 'priv' instead of 'dev',
> causing netdev_priv() inside the ISRs to treat 'priv' as a net_device,
> leading to out-of-bounds pointer calculations and crashes when netconsole
> or netpoll is triggered.
Can we not delete this ndo_poll_controlle and let NAPI polling take
care of netpoll?