Re: [PATCH v2 net-next] octeontx2-af: Add couple of mailbox support.

[Ratheesh Kannoth]

On 2026-09-28 at 08:31:06, netdev-bot+sashiko@xxxxxxxxxx (netdev-bot+sashiko@xxxxxxxxxx) wrote:
> Thank you for your contribution! Sashiko AI review found 8 potential
> issue(s) to consider.
>
> Critical: 0 (1) · High: 1 (4) · Medium: 5 (1) · Low: 2
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] rvu_mbox_handler_nix_lf_alloc() now declares the locals `struct
>   qmem *rq_ctx, *sq_ctx, *cq_ctx;` without initializing them, and…
> - [Medium] The patch rewrites nix_get_tx_link() (rvu_nix.c) and changes
>   what it returns for existing users, not only for the new…
> - [Medium] IFACE_GET_INFO treats `pfvf->tx_chan_cnt != 0` as meaning the
>   interface has a live NIX LF, but the patch clears the channel fields…
> - [Medium] In nix_interface_init(), `lbkid = 0; if (rvu->hw->lbk_links >
>   1) lbkid = ...; if (loop) lbkid = !lbkid;` sets lbkid=1 even when…
> - [Medium] The new rvu_mbox_handler_npc_mcam_mul_stats() decodes the
>   counter selector as `cntr = regval & 0x1FF` before reading…
> - [Medium] rvu_mbox_handler_nix_lf_free() now calls
>   nix_interface_clear_chan(), which sets rx_chan_base to 0.
> - [Low] For the representor, nix_get_tx_link() now returns hw->cgx_links,
>   and IFACE_GET_INFO reports that value.
> - [Low] nix_interface_init() writes pfvf->lbkid without holding
>   rsrc_lock, before nix_interface_set_chan().

ACK.

pw-bot: changes-requested