Re: [PATCH] pwm: tiehrpwm: fix copy-paste error in obsolete DT binding fallback

[Manush Prajwal]

Hi Uwe,

Thanks for the quick review and for digging up the Fixes commit.

> Looks right, I guess it needs:
> Fixes: ae5200d22716 ("pwm: pwm-ti*: Get the clock from the PWMSS parent when using old bindings")
> 
> I wonder: Did you find this because you still use the old bindings, or
> by code inspection somehow? If the latter, maybe it's time to drop the
> handling instead?

This was found purely by code inspection during a review of the PWM
drivers, not from running older bindings on actual hardware.

Given that this fallback in pwm-tiehrpwm has been effectively broken ever
since commit ae5200d22716 was merged in 2014 without anyone noticing or
reporting it, it seems very likely that nobody relies on this obsolete
binding anymore.

I would be happy to send a patch dropping the obsolete binding handling
instead (from pwm-tiehrpwm, or from both pwm-tiehrpwm and pwm-tiecap if
you prefer keeping them consistent).

Or if you'd rather keep backward compatibility, I can send a v2 of this
fix with the Fixes: tag included.

Which direction would you prefer?

Best regards,
Manush