Re: [PATCH] Testing for a forgotten lock...

[syzbot]

> #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git d58dffe9ee2c

This crash does not have a reproducer. I cannot test it.

>
> Signed-off-by: Svyatoslav Nikolenko <nsvatoslav515@xxxxxxxxx>
> ---
>  drivers/memstick/host/rtsx_usb_ms.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/memstick/host/rtsx_usb_ms.c b/drivers/memstick/host/rtsx_usb_ms.c
> index beadc389f15f..98143e13b6a0 100644
> --- a/drivers/memstick/host/rtsx_usb_ms.c
> +++ b/drivers/memstick/host/rtsx_usb_ms.c
> @@ -517,7 +517,10 @@ static void rtsx_usb_ms_handle_req(struct work_struct *work)
>  	if (!host->req) {
>  		pm_runtime_get_sync(ms_dev(host));
>  		do {
> +			mutex_lock(&msh->lock);
>  			rc = memstick_next_req(msh, &host->req);
> +			mutex_unlock(&msh->lock);
> +
>  			dev_dbg(ms_dev(host), "next req %d\n", rc);
>  
>  			if (!rc) {
> -- 
> 2.47.3
>