Re: [PATCH v3] printk: Remove console options before decoding the name

[Petr Mladek]

On Thu 2026-09-24 10:00:57, David Engraf wrote:
> This fixes a regression when a console option includes ':'. Commit
> 7640f1a44eba ("printk: Add match_devname_and_update_preferred_console()")
> introduced console=DEVNAME:0.0 hardware style addressing by looking for a
> colon. If the colon is part of an option the name is handled as devname
> instead of ttyname.
> 
> Fix by handling the options first which will add a NULL terminator to the
> string and refactor idx handling to clean up the code (thanks to Petr
> Mladek).
> 
> Signed-off-by: David Engraf <david.engraf@xxxxxxxxx>

Looks good to me:

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

There is no need to send v4 just to update the commit message. I could
do so when committing the change.

I am going to wait one or two more days for more potential feedback.
Then I'll push it with the updated commit message unless anyone
complains in the meantime.

Best Regards,
Petr