Re: [PATCH v4 1/5] dt-bindings: Add InvenSense ICM-42370-p accelerometer

[Marcelo Schmitt]

Hi Kanak,

On 09/28, Kanak Shilledar wrote:
> Hi Marcelo,
> 
> On Sun, 2026-09-20 at 10:52 -0300, Marcelo Schmitt wrote:
> > Hello Kanak,
> > 
> > On 09/17, Kanak Shilledar wrote:
> > > ICM42370P is a 3-axis accelerometer. The device can support I2C,
> > > SPI
> > > and I3C. Add the supporting devicetree documentation for the
> > > device.
> > > The device supports VDD and VDDIO operating range of 1.71V to 3.6V.
> > > 
> > Patch 3 says ICM-42370-P is almost identical to the existing
> > Invensense ICM-42607-P.
> > Instead of creating a new doc, could we have similar properties for
> > ICM-42370-P
> > by extending
> > Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml?
> > The updates on the other patches keep supporting both ICM-42370-P and
> > ICM-42370-P with the same device driver.
> 
> ICM-42370-P is very similar to ICM-42607-P but it's an accelerometer as
> it does not have gyro. As dt-bindings should describe the hardware I
> think it should be inside the iio/accel/ directory although it is using
> the same driver of IMU. If you think it should be in the same file, I
> will move it and update the binding description.
> 

If ICM-42370-P can be described with the same (or roughly same) dt-properties of
ICM-42607-P, then I'd suggest to extend the existing dt-doc so all devices from
the ICM-42600 series can benefit from updates to icm42600.yaml. ICM-42370-P
being an accelerometer is not an issue according to Rob's reply.

Anyways, the final word is always from dt maintainers.


With best regards,
Marcelo