RE: [PATCH rtw-next 1/2] wifi: rtw88: download the beacon the reserved page was built with

[Ping-Ke Shih]

Mehmet Fide <mehmet.fide@xxxxxxxxx> wrote:
> Hi Luka,
> 
> On 2026-09-29 Luka Gejak wrote:
> > This breaks hardware scan offload while an AP is active.
> >
> > rtw_download_beacon() no longer fetches a beacon of its own. It reads
> > rsvd_pkt->skb, and rtw_fw_download_rsvd_page() clears that skb right
> > before it returns:
> [...]
> > Could the scan path fetch its own beacon, or could the retained skb be
> > released only after the standalone download, with care taken to not
> > advance the CSA countdown twice?
> 
> Thanks, you are right: I checked the callers of
> rtw_fw_download_rsvd_page() and missed rtw_hw_scan_offload().
> 
> v2 takes your first option. rtw_build_rsvd_page() hands the page-0
> beacon skb out to rtw_fw_download_rsvd_page(), which passes it to
> rtw_download_beacon() and frees it afterwards, and rtw_download_beacon()
> fetches (and frees) its own beacon when it is called without one, which
> is what the scan path does. So the countdown still advances once per
> page update and the scan keeps its beacon.

If scan request while doing channel switching, we might deny the scan
since peer (STA) might countdown itself and jump to target channel
but no beacon listened causes disconnection.

Therefore, rtw_download_beacon() fetches its own beacon without affecting
countdown (channel switch isn't operating).

Ping-Ke