Re: [PATCH net v4 14/15] net: stmmac: prepare device-local DMA interrupt quiescence

[netdev-bot+sashiko]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The patch includes an unrelated whitespace-only reflow in
  stmmac_free_irq() (drivers/net/ethernet/stmicro/stmmac/stmmac_main.c).

--

net: stmmac: prepare device-local DMA interrupt quiescence

This commit adds DMA interrupt-mask accessors (set_irq_mask) for the
supported stmmac cores, plus a per-channel irq_quiesced gate that the
channel lock protects. When the gate is set, stmmac_napi_check() masks
the channel's DMA interrupt sources again. It does this without
acknowledging pending events and without touching the rings that are
being replaced.

> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 4d70645c4a4f8..08049c05ffc48 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

[ ... ]

> @@ -3995,8 +4011,7 @@ static void stmmac_free_irq(struct net_device *dev,
>  		for (j = irq_idx - 1; msi && j >= 0; j--) {
>  			if (msi->tx_irq[j] > 0) {
>  				irq_set_affinity_hint(msi->tx_irq[j], NULL);
> -				free_irq(msi->tx_irq[j],
> -					 &priv->channel[j]);
> +				free_irq(msi->tx_irq[j], &priv->channel[j]);
>  			}
>  		}
>  		irq_idx = priv->plat->rx_queues_to_use;
> @@ -4005,8 +4020,7 @@ static void stmmac_free_irq(struct net_device *dev,
>  		for (j = irq_idx - 1; msi && j >= 0; j--) {
>  			if (msi->rx_irq[j] > 0) {
>  				irq_set_affinity_hint(msi->rx_irq[j], NULL);
> -				free_irq(msi->rx_irq[j],
> -					 &priv->channel[j]);
> +				free_irq(msi->rx_irq[j], &priv->channel[j]);

[Severity: Low]
This isn't a bug, but these two hunks in stmmac_free_irq() only join the
tx_irq and rx_irq free_irq() calls onto one line each. Nothing else
changes.

The commit message describes the DMA interrupt-mask accessors and the
irq_quiesced gate. It doesn't mention the IRQ free path, and this reflow
has no connection to interrupt quiescence.

Could the reflow be dropped from this patch, or sent as a separate
cleanup patch?

>  			}
>  		}
>

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260926-submit-stmmac-reset-fixes-v1-v4-0-ec1c0250b3c9%40gmail.com