Re: [PATCHv2] ARM: dts: marvell: armada-388: use onnn,pca9655 compatible

[Gregory CLEMENT]

Rosen Penev <rosenp@xxxxxxxxx> writes:

> The PCA9655s on the ClearFog and Helios4 boards are
> register-compatible with the pca9555, and the gpio-pca953x driver has
> matched "onnn,pca9655" in its OF match table since
> commit 6d49b3a0f351 ("gpio: pca953x: Add support for the On Semi
> pca9655").  OF matching is tried before the legacy I2C ID-table
> matching that the old comment alluded to, so the restriction no longer
> applies.  List the real part and drop the stale comment.
>
> The I2C client is now named "pca9655" instead of "pca9555", but the
> expander is otherwise identical.
>
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>

Applied on mvebu/dt

Thanks,

Gregory
> ---
>  v2: rebase.
>  arch/arm/boot/dts/marvell/armada-388-clearfog.dtsi | 7 +------
>  arch/arm/boot/dts/marvell/armada-388-helios4.dts   | 9 +--------
>  2 files changed, 2 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/boot/dts/marvell/armada-388-clearfog.dtsi b/arch/arm/boot/dts/marvell/armada-388-clearfog.dtsi
> index f8a06ae4a3c9..4a61e9d1a2c0 100644
> --- a/arch/arm/boot/dts/marvell/armada-388-clearfog.dtsi
> +++ b/arch/arm/boot/dts/marvell/armada-388-clearfog.dtsi
> @@ -131,12 +131,7 @@ &i2c0 {
>  	 * 15-SFP_MOD_DEF0
>  	 */
>  	expander0: gpio-expander@20 {
> -		/*
> -		 * This is how it should be:
> -		 * compatible = "onnn,pca9655", "nxp,pca9555";
> -		 * but you can't do this because of the way I2C works.
> -		 */
> -		compatible = "nxp,pca9555";
> +		compatible = "onnn,pca9655";
>  		gpio-controller;
>  		#gpio-cells = <2>;
>  		reg = <0x20>;
> diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> index 39b2d4fa742c..bf6d70e2078b 100644
> --- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> +++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> @@ -160,14 +160,7 @@ i2c@11000 {
>  				 *  6-USB3 power
>  				 */
>  				expander0: gpio-expander@20 {
> -					/*
> -					 * This is how it should be:
> -					 * compatible = "onnn,pca9655",
> -					 *	 "nxp,pca9555";
> -					 * but you can't do this because of
> -					 * the way I2C works.
> -					 */
> -					compatible = "nxp,pca9555";
> +					compatible = "onnn,pca9655";
>  					gpio-controller;
>  					#gpio-cells = <2>;
>  					reg = <0x20>;
> -- 
> 2.55.0
>

-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com