Re: [PATCH 2/3] sched_ext: Call ops.dequeue() when a task arrives on a remote local DSQ
From: Kuba Piecuch
Date: Wed Sep 30 2026 - 07:52:01 EST
Hi Andrea,
On Tue, Sep 29, 2026 at 08:33:45PM +0200, Andrea Righi wrote:
> Nit: nothing between the top of enqueue_task_scx() and scx_do_enqueue_task()
> looks at p->scx.sticky_cpu, so p->scx.sticky_cpu = -1 could go right after
> reading it into the local variable, as it was before b75aaea24c9f. Same
> behavior, but it also covers the SCX_TASK_QUEUED early exit, which currently
> leaves p->scx.sticky_cpu set and essentially makes the fix a revert of the
> enqueue side of b75aaea24c9f.
Makes sense, done in v2. The clear is right after the local copy is taken,
guarded by "if (sticky_cpu >= 0)" as before b75aaea24c9f.
> Either way:
>
> Reviewed-by: Andrea Righi <arighi@xxxxxxxxxx>
Thanks! I kept your tag in v2. The only other changes to this patch are
the comment and description rewording that Tejun asked for, plus the
7.1.y prerequisite note.
Thanks,
Kuba