Re: [PATCH net-next v3 2/8] dt-bindings: net: Add SoC-e SWIP MDIO controller
From: Andrew Lunn
Date: Wed Sep 30 2026 - 11:22:10 EST
On Wed, Sep 30, 2026 at 04:00:56PM +0200, Vasilij Strassheim wrote:
> On Sat, 2026-09-26 at 00:55 +0200, Andrew Lunn wrote:
> > > The controller exposes separate register regions for transaction data
> > > and for the shared transaction control and external bus selector
> > > register.
> >
> > > +examples:
> > > + - |
> > > + mdio@204 {
> > > + compatible = "soce,swip-mdio-23-02";
> > > + reg = <0x204 0xc>, <0x200 0x4>;
> >
> > At least in the example, they are not separate?
>
> Not separate regions but registers...
> I'm obviously bad at documenting things.
>
> The current information in the commit message is misleading and
> irrelevant. Looking at the bot's feedback, it's at the same time not
> clear enough yet that the mdio controller part is mapped within the
> switch memory and can't be used separately from it.
>
> I will update the commit message to something like this:
> Add a binding for the MDIO controller integrated into SoC-e SWIP
> Ethernet switch IP cores.
> The controller shares the memory of the synthesized switch IP core and
> cannot be used independently.
I think part of the issue is the compatible. That suggests it is a
separate device, with its own driver. But it is actually driven by the
switch driver.
Andrew