Re: [PATCH v2 2/2] x86,fs/resctrl: Use a consistent log prefix

[Reinette Chatre]

Hi Babu,

Thank you very much for doing this.

On 9/29/26 3:39 PM, Babu Moger wrote:
> resctrl code is split between arch and fs/resctrl/. Some files derive the
> printk prefix from KBUILD_MODNAME, while others use "resctrl: ". Since
> KBUILD_MODNAME follows the object name, messages use different prefixes
> such as "rdtgroup:", "ctrlmondata:", and "pseudo_lock:".
> 
> Use "resctrl: " throughout both directories so all resctrl messages have
> the same subsystem prefix.
> 
> Suggested-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
> Signed-off-by: Babu Moger <babu.moger@xxxxxxx>
> ---

...

> diff --git a/arch/x86/kernel/cpu/resctrl/intel_aet.c b/arch/x86/kernel/cpu/resctrl/intel_aet.c
> index c22c3cf5167d..04b665277884 100644
> --- a/arch/x86/kernel/cpu/resctrl/intel_aet.c
> +++ b/arch/x86/kernel/cpu/resctrl/intel_aet.c
> @@ -9,7 +9,7 @@
>   *    Tony Luck <tony.luck@xxxxxxxxx>
>   */
>  
> -#define pr_fmt(fmt)   "resctrl: " fmt
> +#define pr_fmt(fmt)	"resctrl: " fmt
>  

This hunk is a bit out of place since it is just a whitespace change. To avoid this
surprise could you please add a snippet like: "Match indentation in files that already
use the right prefix." to the changelog?

| Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Reinette