Re: [PATCH net-next v3 7/8] net: dsa: soce: Add VLAN offload support

From: Vasilij Strassheim

Date: Wed Sep 30 2026 - 14:39:42 EST


On Sat, 2026-09-26 at 01:32 +0200, Andrew Lunn wrote:
> > The port and VID selectors are shared by all VLAN operations, so
> > serialize selector and data register sequences with a dedicated mutex.
> > Track member and untagged masks in software and restore the shadow state
> > if programming fails.
>
> Looking at other features of the switch, how many different mutex are
> going to be needed? Is it better to have a single mutex which protects
> everything?

Yes, this all relates to configuration and is therefore not critical.
One mutex is sufficient and makes the code clearer.
I will change that.

>
> Andrew

Thanks,
Vasilij