Re: [PATCH v2 1/2] x86/resctrl: Rename AMD resctrl MSR defines to use MSR_AMD_ prefix

[Moger, Babu]

Hi Reinette,

On 9/30/2026 12:23 PM, Reinette Chatre wrote:
> Hi Babu,
>
> On 9/29/26 3:39 PM, Babu Moger wrote:
> > ---
> >   arch/x86/include/asm/msr-index.h          | 10 +++++-----
> >   arch/x86/kernel/cpu/resctrl/core.c        |  4 ++--
> >   arch/x86/kernel/cpu/resctrl/ctrlmondata.c |  6 +++---
> >   arch/x86/kernel/cpu/resctrl/internal.h    |  6 +++---
> >   arch/x86/kernel/cpu/resctrl/monitor.c     |  8 ++++----
> >   arch/x86/kernel/cpu/resctrl/rdtgroup.c    |  4 ++--
> >   fs/resctrl/rdtgroup.c                     |  4 ++--
>
> nit: subject prefix is missing the update to filesystem code:
> 	x86,fs/resctrl: Rename AMD resctrl MSR defines to use MSR_AMD_ prefix

Sure.

> sidenote (not a critique of this change since it just renames
> existing things): we should aim to avoid using architecture
> specific register names in resctrl filesystem code.

Agree.

> | Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Thanks
Babu