Re: [PATCH v2 0/2] mm/mremap: fix two issues with MREMAP_DONTUNMAP

[Lorenzo Stoakes (ARM)]

On Wed, Sep 30, 2026 at 03:21:39PM -0700, Andrew Morton wrote:
> On Wed, 30 Sep 2026 19:47:08 +0100 "Lorenzo Stoakes (ARM)" <ljs@xxxxxxxxxx> wrote:

> > v2:
> > * Added tags (thanks everybody!)
> > * Updated 2/2 to avoid splitting the VMA if the VMA was not mlock()'d. It
> >   is only meaningful and necessary to perform the split in this case. This
> >   also fixes the proc_maps_race selftests that broke, as reported by
> >   Anirudh.
>
> Here's how v2 altered mm.git's mm-hotfixes-unstable branch.  Quite a
> large change - are you sure that retaining the tags was appropriate?

It's not a large change conceptually.

The dontunmap_complete() delta is just reverting it to what it was before.

The rest of it is literally just checking for VMA_LOCKED_BIT to avoid an
unnecessary split.

So yeah I think fine to retain tags.

--
Cheers, Lorenzo