Re: [PATCH] serial: ma35d1: unmap MMIO on remove

[Greg KH]

On Thu, Sep 24, 2026 at 07:04:00PM +0800, Guangshuo Li wrote:
> ma35d1serial_probe() maps up->port.membase with ioremap(), but
> ma35d1serial_remove() does not perform the matching iounmap(). The probe
> error path already releases this mapping after disabling the clock.
> 
> Add iounmap() to the remove path after clk_disable_unprepare() to match
> the resource cleanup order used by ma35d1serial_probe().
> 
> Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support")
> Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>
> ---
>  drivers/tty/serial/ma35d1_serial.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c
> index 920fe7ff5083..e5eaaf154911 100644
> --- a/drivers/tty/serial/ma35d1_serial.c
> +++ b/drivers/tty/serial/ma35d1_serial.c
> @@ -770,6 +770,7 @@ static void ma35d1serial_remove(struct platform_device *dev)
>  
>  	uart_remove_one_port(&ma35d1serial_reg, port);
>  	clk_disable_unprepare(up->clk);
> +	iounmap(up->port.membase);
>  }
>  
>  static int ma35d1serial_suspend(struct platform_device *dev, pm_message_t state)
> 
> base-commit: f03c39de3a1307371a4032757cd1732e91087c7d
> -- 
> 2.43.0
> 

Did you forget an Assisted-by: tag?

thanks,

greg k-h