Re: [PATCH 1/2] dt-bindings: display: panel: add optional wled-supply
From: Dmitry Baryshkov
Date: Thu Oct 01 2026 - 06:11:35 EST
On Thu, Oct 01, 2026 at 08:57:52AM +0200, Krzysztof Kozlowski wrote:
> On 01/10/2026 08:55, Krzysztof Kozlowski wrote:
> > On Tue, Sep 29, 2026 at 06:42:20PM +0530, Arpit Saini wrote:
> >> Some boards drive the ILI7807S panel's backlight from an external
> >> WLED driver whose enable input is wired to a GPIO, typically modeled
> >> as a fixed regulator (e.g. vreg_wled).
> >
> > You describe something else. What's fixed regulator should not matter
> > here. Which pin is it in ILI7807S?
> >
> > It seems you just want to represent GPIO with a regulator. This is just
> > confusing and typical downstream workaround.
>
> What's more, you basically REVERT the review YOU RECEIVED in v1. Really,
> just sneak the same stuff 3 months after like the review never happened.
>
> NAK
After discussing this offline with Krzysztof. It's not a supply (my
fault), it's an LCD driver. So, the best way to handle your displaycard
seems to add a gpio-backlight, reference it from the panel and then in
the driver check for the backlight's max_brightness level. If it's 1,
then you have to send extra DCS commands to control PWM. If it's
higher, use normal backlight class controls.
--
With best wishes
Dmitry