Re: [PATCH] staging: rtl8723bs: refactor xmit_xmitframe

[Dan Carpenter]

On Thu, Oct 01, 2026 at 11:34:30AM +0200, Greg Kroah-Hartman wrote:
> > +					if (pxmitbuf->len > 0 &&
> > +					    pxmitbuf->priv_data) {
> > +						struct xmit_frame *pframe;
> > +
> > +						pframe = (struct xmit_frame *)pxmitbuf->priv_data;
> > +						pframe->agg_num = k;
> > +						pxmitbuf->agg_num = k;
> > +						rtl8723b_update_txdesc(pframe, pframe->buf_addr);
> > +						rtw_free_xmitframe(pxmitpriv, pframe);
> > +						pxmitbuf->priv_data = NULL;
> > +						enqueue_pending_xmitbuf(pxmitpriv, pxmitbuf);
> > +						/* can not yield under lock */
> > +						/* yield(); */
> > +					} else
> > +						rtw_free_xmitbuf(pxmitpriv, pxmitbuf);
> > +
> > +					pxmitbuf = NULL;
> 
> This jumped out at me, why add this new line?
> 

The patch is correct but the new version is as confusing as heck...
Glad that I'm not the only person who thinks this.  I've been doing
more and more AI coding these days and they say that AI makes you
stupid so I was worried about my own brain health.

regards,
dan carpenter