Re: [PATCH] staging: rtl8723bs: rename phy_status_rpt_8192cd_t to rtl8723bs_phy_status_rpt.

[Greg Kroah-Hartman]

On Thu, Oct 01, 2026 at 02:17:00PM +0200, Timo Joannin wrote:
> The struct identifier references the 8192CD chip while being in a
> rtl8723bs codebase. Additionally, the identifier uses the _t suffix,
> while being generally reserved for typedef identifiers.
> 
> Rename the struct to rtl8723bs_phy_status_rpt
> across the rtl8723bs driver to accurately
> reflect the codebase and clean up the naming.
> 
> Signed-off-by: Timo Joannin <timo.joannin@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 3 ++-
>  drivers/staging/rtl8723bs/hal/odm_HWConfig.h | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> index 34b0369a7936..bf2479c01873 100644
> --- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> +++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> @@ -105,7 +105,8 @@ static void odm_rx_phy_status_parsing(struct dm_odm_t *dm_odm,
>  	bool is_cck_rate = false;
>  	u8 rf_rx_num = 0;
>  	u8 lna_idx, vga_idx;
> -	struct phy_status_rpt_8192cd_t *phy_sta_rpt = (struct phy_status_rpt_8192cd_t *)phy_status;
> +	struct rtl8723bs_phy_status_rpt *phy_sta_rpt =
> +		(struct rtl8723bs_phy_status_rpt *)phy_status;

Why is this pointer being cast from a structure type, to a u8 *, and now
back to the real structure again?  That's a mess, please propagate the
real structure type all the way through the call chain so that there is
no more casts needed.

thanks,

greg k-h