Re: [PATCH] xfs: Fix duplicate assignment in xfs_alloc_read_agf.

[Darrick J. Wong]

On Thu, Oct 01, 2026 at 08:21:53PM +0530, Siddh Raman Pant wrote:
> Probably an (harmless) error in copy-paste.
> 
> Fixes: db6a2274162d ("xfs: catch stale AGF/AGF metadata")
> Cc: stable@xxxxxxxxxxxxxxx

Cc: <stable@xxxxxxxxxxxxxxx> # v6.16
Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>

--D

> Signed-off-by: Siddh Raman Pant <siddh.raman.pant@xxxxxxxxxx>
> ---
> Put in stables <= 6.12 after the backport series lands.
> 
>  fs/xfs/libxfs/xfs_alloc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
> index f762dcce8d13..0ffa82400007 100644
> --- a/fs/xfs/libxfs/xfs_alloc.c
> +++ b/fs/xfs/libxfs/xfs_alloc.c
> @@ -3461,7 +3461,6 @@ xfs_alloc_read_agf(
>  	if (!xfs_is_shutdown(pag_mount(pag))) {
>  		bool	ok = true;
>  
> -		ok &= pag->pagf_freeblks == be32_to_cpu(agf->agf_freeblks);
>  		ok &= pag->pagf_freeblks == be32_to_cpu(agf->agf_freeblks);
>  		ok &= pag->pagf_btreeblks == be32_to_cpu(agf->agf_btreeblks);
>  		ok &= pag->pagf_flcount == be32_to_cpu(agf->agf_flcount);
> -- 
> 2.53.0
> 
>